Pva/bugfixes for cdisc subsets and banner #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com/NCIEVS/evs-explore into pva/bugfixes-for-CDISC-subsets-and-banner
gaaliciA1990
approved these changes
Nov 19, 2024
web/frontend/src/app/component/subset-details/subset-details.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a check for RDFBROWSER-478 that nixes the display of the subset link if we detect that said link is already in the description. It also fixes a couple non-ticketed bugs that Jason mentioned to me with subset displays and multi-terminology search, mostly with expanded error checking in certain places.
https://tracker.nci.nih.gov/browse/RDFBROWSER-478
As of the opening of this PR this branch is up on dev/qa for Jason to test